refactor: Update to use IFocusableNode in place of INavigable.#520
Merged
refactor: Update to use IFocusableNode in place of INavigable.#520
IFocusableNode in place of INavigable.#520Conversation
gonfunko
requested review from
RoboErikG and
rachel-fenichel
and removed request for
a team
Collaborator
|
|
Merged
1 task
Contributor
Author
|
Already had them, just needed to be re-run after checking in the core change. |
Contributor
|
I think the failing tests are from the change in behavior to skip connections. You can double check by increasing the pause timeout to watch it go and then update the expected end position. |
1 task
RoboErikG
approved these changes
May 14, 2025
Contributor
RoboErikG
left a comment
RoboErikG
left a comment
There was a problem hiding this comment.
Approved. Feel free to submit as is or make the proposed tweak to use assert.equal instead. The .to.include call is only needed for fields and connections since they get a generated string appended to their id. This means technically any of the sub-elements of the block would also match the .include version and pass the test.
maribethb
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the keyboard experiment for compatibility with RaspberryPiFoundation/blockly#9037 by using IFocusableNode in place of INavigable.